linux-kernel - Re: [PATCH 4/6] input/vmmouse: Use vmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231124194646.GW50352@kernel.org>
Date:   Fri, 24 Nov 2023 19:46:46 +0000
From:   Simon Horman <horms@...nel.org>
To:     Alexey Makhalov <amakhalov@...are.com>
Cc:     linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
        hpa@...or.com, x86@...nel.org, dave.hansen@...ux.intel.co,
        bp@...en8.d, mingo@...hat.com, tglx@...utronix.de,
        zackr@...are.com, timothym@...are.com,
        dri-devel@...ts.freedesktop.org, daniel@...ll.ch,
        airlied@...il.com, tzimmermann@...e.de, mripard@...nel.org,
        maarten.lankhorst@...ux.intel.com, netdev@...r.kernel.org,
        richardcochran@...il.com, linux-input@...r.kernel.org,
        dmitry.torokhov@...il.com, linux-graphics-maintainer@...are.com,
        pv-drivers@...are.com, namit@...are.com, akaher@...are.com,
        jsipek@...are.com
Subject: Re: [PATCH 4/6] input/vmmouse: Use vmware_hypercall API

On Wed, Nov 22, 2023 at 03:30:49PM -0800, Alexey Makhalov wrote:
> Switch from VMWARE_HYPERCALL macro to vmware_hypercall API.
> Eliminate arch specific code. No functional changes intended.
> 
> Signed-off-by: Alexey Makhalov <amakhalov@...are.com>

Hi Alexey,

it is not strictly related to this patch, but I notice than an x86_64
allmodconfig build with W=1 using gcc-13 fails to compile this file.

It appears that the problem relates to both priv->phys and
psmouse->ps2dev.serio->phys being 32 bytes.


drivers/input/mouse/vmmouse.c: In function ‘vmmouse_init’:
drivers/input/mouse/vmmouse.c:455:53: error: ‘/input1’ directive output may be truncated writing 7 bytes into a region of size between 1 and 32 [-Werror=format-truncation=]
  455 |         snprintf(priv->phys, sizeof(priv->phys), "%s/input1",
      |                                                     ^~~~~~~
drivers/input/mouse/vmmouse.c:455:9: note: ‘snprintf’ output between 8 and 39 bytes into a destination of size 32
  455 |         snprintf(priv->phys, sizeof(priv->phys), "%s/input1",
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  456 |                  psmouse->ps2dev.serio->phys);
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

...