linux-kernel - Re: [PATCH v2 7/9] irqchip: Add RISC-V advanced PLIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAK9=C2V4Gkx6tcymNdm=WmPv+vqFgJ=0hm2hrPw7kS0qGP79yg@mail.gmail.com>
Date:   Fri, 24 Nov 2023 10:35:14 +0530
From:   Anup Patel <apatel@...tanamicro.com>
To:     谢 波 <xiebo_60@...e.com>
Cc:     "Alistair.Francis@....com" <Alistair.Francis@....com>,
        "anup@...infault.org" <anup@...infault.org>,
        "atishp@...shpatra.org" <atishp@...shpatra.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "maz@...nel.org" <maz@...nel.org>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>
Subject: Re: [PATCH v2 7/9] irqchip: Add RISC-V advanced PLIC driver

On Fri, Nov 24, 2023 at 8:33 AM 谢 波 <xiebo_60@...e.com> wrote:
>
> Hello all,
>
>
> I have a question regarding the handling of potential issues during the MSI interrupt sending process. It appears that if the APLIC target register's value is modified during the MSI interrupt sending process, it could potentially lead to MSI interrupt send failures. The code doesn't seem to account for this scenario or take appropriate measures.
>
> I am reaching out to seek clarification on whether this situation has been considered and if there are specific reasons for not addressing it in the code. Your insights into this matter would be highly appreciated.
>
> Thank you for your time, and I look forward to your response.

This has been taken care of in the IMSIC driver in the irq_set_affinity()
because the IMSIC driver manages the re-writing of MSI messages
upon IRQ affinity changes.

Please look at PATCH7 and PATCH8 of the "[PATCH v11 00/14] Linux
RISC-V AIA Support" series.
(Refer, https://www.spinics.net/lists/devicetree/msg643764.html)

Regards,
Anup

>
> Best regards
>
>
>