linux-kernel - Re: [PATCH v3 03/21] dentry: switch the lists of children to hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOQ4uxhVCzJtX7sNqHH2btkGY-Lnin4GjvXJv1nEEfk-O+EK_g@mail.gmail.com>
Date:   Fri, 24 Nov 2023 10:02:46 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Christian Brauner <brauner@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 03/21] dentry: switch the lists of children to hlist

On Fri, Nov 24, 2023 at 9:55 AM Al Viro <viro@...iv.linux.org.uk> wrote:
>
> On Fri, Nov 24, 2023 at 09:44:27AM +0200, Amir Goldstein wrote:
> > On Fri, Nov 24, 2023 at 8:05 AM Al Viro <viro@...iv.linux.org.uk> wrote:
> > >
> > > Saves a pointer per struct dentry and actually makes the things less
> > > clumsy.  Cleaned the d_walk() and dcache_readdir() a bit by use
> > > of hlist_for_... iterators.
> > >
> > > A couple of new helpers - d_first_child() and d_next_sibling(),
> > > to make the expressions less awful.
> > >
> > > X-fuck-kABI: gladly
> >
> > ???
>
> It breaks kABI.  Hard.  For a good reason.  And if you need an elaboration
> of the reasons why kABI is, er, not universally liked - let's take it
> to private email.  Some rants are really too unprintable for maillists...

I don't mind rants, even quite fond of yours :)

But "X-fuck-kABI: gladly" serves no real value.
You'd already documented the kAPI change in porting.rst.
If you want to add a note about kABI, I suggest that you add it there.

Thanks,
Amir.