linux-kernel - Re: [PATCH -next v2 1/6] md: remove useless debug code to print configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW5=fDpsAofik+4jHObFkRMcTTeQPbtXSBG_KAes0YgQGA@mail.gmail.com>
Date:   Fri, 24 Nov 2023 00:17:34 -0800
From:   Song Liu <song@...nel.org>
To:     Yu Kuai <yukuai1@...weicloud.com>
Cc:     linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH -next v2 1/6] md: remove useless debug code to print configuration

On Fri, Oct 20, 2023 at 7:25 PM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> One the one hand, print_conf() can be called without grabbing
> 'reconfig_mtuex' and current rcu protection to access rdev through 'conf'
> is not safe. Fortunately, there is a separate rcu protection to access
> rdev from 'mddev->disks', and rdev is always removed from 'conf' before
> 'mddev->disks'.
>
> On the other hand, print_conf() is just used for debug,
> and user can always grab such information(/proc/mdstat and mdadm).
>
> There is no need to always enable this debug and try to fix misuse rcu
> protection for accessing rdev from 'conf', hence remove print_conf().
>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

I wouldn't call these debug functions useless. There is probably some
users who use them for debugging (or even in some automations).
How hard is it to keep these functions? Can we just add some lockdep
to these functions to make sure they are called from safe places?

Thanks,
Song

[...]