linux-kernel - Re: [PATCH v3 1/1] drm/mediatek: Fix errors when reporting rotation capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8caf6b3f146850636a7decdedf487e5dc067de18.camel@mediatek.com>
Date:   Fri, 24 Nov 2023 09:41:16 +0000
From:   Shawn Sung (宋孝謙) 
        <Shawn.Sung@...iatek.com>
To:     CK Hu (胡俊光) <ck.hu@...iatek.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "seanpaul@...omium.org" <seanpaul@...omium.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "airlied@...il.com" <airlied@...il.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH v3 1/1] drm/mediatek: Fix errors when reporting rotation
 capability

Hi CK,

On Tue, 2023-11-21 at 02:57 +0000, CK Hu (胡俊光) wrote:
> Hi, Hsiao-chien:
> 
> On Mon, 2023-11-20 at 15:12 +0800, Hsiao Chien Sung wrote:
> > Create rotation property according to the hardware capability.
> > 
> > Fixes: 84d805753983 ("drm/mediatek: Support reflect-y plane
> > rotation")
> 
> In Sean Paul's patch (the patch you fix), ovl driver only support
> mt8127 and mt8173, and I believe that Sean has tested on mt8173. In
> this patch, only mt8195 ovl support rotation, why do you do this
> modification? Please describe which SoC is wrong in commit message so
> I
> could know how the code should be.

Thanks for checking. According to the cover letter by Sean, his fix was
verified on mt8183, but it will be applied to all the chips. Since for
now OVL on all chips support same rotation, will remove it from the
driver data and return rotation property directly.

Regards,
Shawn