linux-kernel - Re: [PATCH] perf lock: Fix a memory leak on an error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231124095319.GN3818@noisy.programming.kicks-ass.net>
Date:   Fri, 24 Nov 2023 10:53:19 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     zhaimingbing <zhaimingbing@...s.chinamobile.com>
Cc:     Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Li Dong <lidong@...o.com>, linux-perf-users@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf lock: Fix a memory leak on an error path

On Fri, Nov 24, 2023 at 05:26:57PM +0800, zhaimingbing wrote:
> if a strdup-ed string is NULL,the allocated memory needs freeing.
> 
> Signed-off-by: zhaimingbing <zhaimingbing@...s.chinamobile.com>
> ---
>  tools/perf/builtin-lock.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index b141f2134..086041bcb 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -2228,8 +2228,10 @@ static int __cmd_record(int argc, const char **argv)
>  		else
>  			ev_name = strdup(contention_tracepoints[j].name);
>  
> -		if (!ev_name)
> +		if (!ev_name) {
> +			free(rec_argv);
>  			return -ENOMEM;
> +		}

Isn't this an error path straight into exit?