linux-kernel - Re: [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6bb4d6bb-3857-4ad3-b0a3-498a8950305e@gmail.com>
Date:   Fri, 24 Nov 2023 11:15:15 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Wolfram Sang <wsa@...nel.org>, Sergey Kozlov <serjk@...up.ru>,
        linux-i2c@...r.kernel.org, Abylay Ospan <aospan@...up.ru>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c:
 Don't let i2c adapters declare I2C_CLASS_SPD support if they support
 I2C_CLASS_HWMON

On 23.11.2023 21:55, Wolfram Sang wrote:
> On Sat, Nov 18, 2023 at 07:05:02PM +0100, Heiner Kallweit wrote:
>> After removal of the legacy eeprom driver the only remaining I2C
>> client device driver supporting I2C_CLASS_SPD is jc42. Because this
>> driver also supports I2C_CLASS_HWMON, adapters don't have to
>> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
>> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>>
>> Series was created supported by Coccinelle and its splitpatch.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 
> As I want to apply this cleanup early in the cycle, could we have an ack
> for me to modify this subsystem, please?
> 
Looking at the git history for this driver, there has been no sign of
life from the official maintainers for years. Hopefully Mauro can ack this.

>>
>> ---
>>  drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
>> index bd38ce444..46676f2c8 100644
>> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
>> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
>> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
>>  static const struct i2c_adapter netup_i2c_adapter = {
>>  	.owner		= THIS_MODULE,
>>  	.name		= NETUP_UNIDVB_NAME,
>> -	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
>> +	.class		= I2C_CLASS_HWMON,
>>  	.algo		= &netup_i2c_algorithm,
>>  };
>>  
>>