linux-kernel - Re: [PATCH] cpufreq/amd-pstate: Fix the return value of amd_pstate_fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZWB6Fb3KcqC1fqbD@BLR-5CG11610CF.amd.com>
Date:   Fri, 24 Nov 2023 15:55:25 +0530
From:   "Gautham R. Shenoy" <gautham.shenoy@....com>
To:     Huang Rui <ray.huang@....com>
Cc:     "Karny, Wyes" <Wyes.Karny@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq/amd-pstate: Fix the return value of
 amd_pstate_fast_switch()

On Fri, Nov 24, 2023 at 03:31:34PM +0800, Huang Rui wrote:
> On Fri, Nov 24, 2023 at 12:23:58PM +0800, Karny, Wyes wrote:
> > On 23 Nov 13:57, Gautham R. Shenoy wrote:
> > > cpufreq_driver->fast_switch() callback expects a frequency as a return
> > > value. amd_pstate_fast_switch() was returning the return value of
> > > amd_pstate_update_freq(), which only indicates a success or failure.
> > > 
> > > Fix this by making amd_pstate_fast_switch() return the target_freq
> > > when the call to amd_pstate_update_freq() is successful, and return
> > > the current frequency from policy->cur when the call to
> > > amd_pstate_update_freq() is unsuccessful.
> > > 
> > > Fixes: 4badf2eb1e98 ("cpufreq: amd-pstate: Add ->fast_switch() callback")
> > 
> > Reviewed-by: Wyes Karny <wyes.karny@....com>
> > 
> 
> Acked-by: Huang Rui <ray.huang@....com>

Thanks!
> 
> Do you want to cc stable mailing list to fix it in stable kernels?

Yes, I forgot to do that. I will send a v2 having collected your
Acked-by and the Reviewed-by's from Perry and Wyes.

> 
> Thanks,
> Ray

--
Thanks and Regards
gautham.