| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231124132626.235350-11-david@redhat.com>
Date: Fri, 24 Nov 2023 14:26:15 +0100
From: David Hildenbrand <david@...hat.com>
To: linux-kernel@...r.kernel.org
Cc: linux-mm@...ck.org, David Hildenbrand <david@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Ryan Roberts <ryan.roberts@....com>,
Matthew Wilcox <willy@...radead.org>,
Hugh Dickins <hughd@...gle.com>,
Yin Fengwei <fengwei.yin@...el.com>,
Yang Shi <shy828301@...il.com>,
Ying Huang <ying.huang@...el.com>, Zi Yan <ziy@...dia.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
Waiman Long <longman@...hat.com>,
"Paul E. McKenney" <paulmck@...nel.org>
Subject: [PATCH WIP v1 10/20] mm/memory: COW reuse support for PTE-mapped THP with rmap IDs
For now, we only end up reusing small folios and PMD-mapped large folios
(i.e., THP) after fork(); PTE-mapped THPs are never reused, except when
only a single page of the folio remains mapped. Instead, we end up copying
each subpage even though the THP might be exclusive to the MM.
The logic we're using for small folios and PMD-mapped THPs is the
following: Is the only reference to the folio from a single page table
mapping? Then:
(a) There are no other references to the folio from other MMs
(e.g., page table mapping, GUP)
(b) There are no other references to the folio from page migration/
swapout/swapcache that might temporarily unmap the folio.
Consequently, the folio is exclusive to that process and can be reused.
In that case, we end up with folio_refcount(folio) == 1 and an implied
folio_mapcount(folio) == 1, while holding the page table lock and the
page lock to protect against possible races.
For PTE-mapped THP, however, we have not one, but multiple references
from page tables, whereby such THPs can be mapped into multiple
page tables in the MM.
Reusing the logic that we use for small folios and PMD-mapped THPs means,
that when reusing a PTE-mapped THP, we want to make sure that:
(1) All folio references are from page table mappings.
(2) All page table mappings belong to the same MM.
(3) We didn't race with (un)mapping of the page related to other page
tables, such that the mapcount and refcount are stable.
For (1), we can check
folio_refcount(folio) == folio_mapcount(folio)
For (2) and (3), we can use our new rmap ID infrastructure.
We won't bother with the swapcache and LRU cache for now. Add some sanity
checks under CONFIG_DEBUG_VM, to identify any obvious problems early.
Signed-off-by: David Hildenbrand <david@...hat.com>
---
mm/memory.c | 89 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 89 insertions(+)
diff --git a/mm/memory.c b/mm/memory.c
index 5048d58d6174..fb533995ff68 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3360,6 +3360,95 @@ static vm_fault_t wp_page_shared(struct vm_fault *vmf, struct folio *folio)
static bool wp_can_reuse_anon_folio(struct folio *folio,
struct vm_area_struct *vma)
{
+#ifdef CONFIG_RMAP_ID
+ if (folio_test_large(folio)) {
+ bool retried = false;
+ unsigned long start;
+ int mapcount, i;
+
+ /*
+ * The assumption for anonymous folios is that each page can
+ * only get mapped once into a MM. This also holds for
+ * small folios -- except when KSM is involved. KSM does
+ * currently not apply to large folios.
+ *
+ * Further, each taken mapcount must be paired with exactly one
+ * taken reference, whereby references must be incremented
+ * before the mapcount when mapping a page, and references must
+ * be decremented after the mapcount when unmapping a page.
+ *
+ * So if all references to a folio are from mappings, and all
+ * mappings are due to our (MM) page tables, and there was no
+ * concurrent (un)mapping, this folio is certainly exclusive.
+ *
+ * We currently don't optimize for:
+ * (a) folio is mapped into multiple page tables in this
+ * MM (e.g., mremap) and other page tables are
+ * concurrently (un)mapping the folio.
+ * (b) the folio is in the swapcache. Likely the other PTEs
+ * are still swap entries and folio_free_swap() would fail.
+ * (c) the folio is in the LRU cache.
+ */
+retry:
+ start = raw_read_atomic_seqcount(&folio->_rmap_atomic_seqcount);
+ if (start & ATOMIC_SEQCOUNT_WRITERS_MASK)
+ return false;
+ mapcount = folio_mapcount(folio);
+
+ /* Is this folio possibly exclusive ... */
+ if (mapcount > folio_nr_pages(folio) || folio_entire_mapcount(folio))
+ return false;
+
+ /* ... and are all references from mappings ... */
+ if (folio_ref_count(folio) != mapcount)
+ return false;
+
+ /* ... and do all mappings belong to us ... */
+ if (!__folio_has_large_matching_rmap_val(folio, mapcount, vma->vm_mm))
+ return false;
+
+ /* ... and was there no concurrent (un)mapping ? */
+ if (raw_read_atomic_seqcount_retry(&folio->_rmap_atomic_seqcount,
+ start))
+ return false;
+
+ /* Safety checks we might want to drop in the future. */
+ if (IS_ENABLED(CONFIG_DEBUG_VM)) {
+ unsigned int mapcount;
+
+ if (WARN_ON_ONCE(folio_test_ksm(folio)))
+ return false;
+ /*
+ * We might have raced against swapout code adding
+ * the folio to the swapcache (which, by itself, is not
+ * problematic). Let's simply check again if we would
+ * properly detect the additional reference now and
+ * properly fail.
+ */
+ if (unlikely(folio_test_swapcache(folio))) {
+ if (WARN_ON_ONCE(retried))
+ return false;
+ retried = true;
+ goto retry;
+ }
+ for (i = 0; i < folio_nr_pages(folio); i++) {
+ mapcount = page_mapcount(folio_page(folio, i));
+ if (WARN_ON_ONCE(mapcount > 1))
+ return false;
+ }
+ }
+
+ /*
+ * This folio is exclusive to us. Do we need the page lock?
+ * Likely not, and a trylock would be unfortunate if this
+ * folio is mapped into multiple page tables and we get
+ * concurrent page faults. If there would be references from
+ * page migration/swapout/swapcache, we would have detected
+ * an additional reference and never ended up here.
+ */
+ return true;
+ }
+#endif /* CONFIG_RMAP_ID */
/*
* We have to verify under folio lock: these early checks are
* just an optimization to avoid locking the folio and freeing
--
2.41.0
Powered by blists - more mailing lists