linux-kernel - Re: [PATCH v2] dmaengine: apple-admac: Keep upper bits of REG_BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <170083280044.771517.11806054531627846759.b4-ty@kernel.org>
Date:   Fri, 24 Nov 2023 19:03:20 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Hector Martin <marcan@...can.st>, Sven Peter <sven@...npeter.dev>,
        Martin Povišer <povik+lin@...ebit.org>
Cc:     Alyssa Rosenzweig <alyssa@...enzweig.io>, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: apple-admac: Keep upper bits of
 REG_BUS_WIDTH


On Sun, 29 Oct 2023 18:07:04 +0100, Martin Povišer wrote:
> For RX channels, REG_BUS_WIDTH seems to default to a value of 0xf00, and
> macOS preserves the upper bits when setting the configuration in the
> lower ones. If we reset the upper bits to 0, this causes framing errors
> on suspend/resume (the data stream "tears" and channels get swapped
> around). Keeping the upper bits untouched, like the macOS driver does,
> fixes this issue.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: apple-admac: Keep upper bits of REG_BUS_WIDTH
      commit: 306f5df81fcc89b462fbeb9dbe26d9a8ad7c7582

Best regards,
-- 
~Vinod