linux-kernel - Re: [PATCH] rust: replace <linux/module.h> with <linux/export.h> in rust/exports.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b224ebc-fcb0-4825-9222-5f0efc61c62a@gmail.com>
Date:   Fri, 24 Nov 2023 11:54:01 -0300
From:   Martin Rodriguez Reboredo <yakoyoku@...il.com>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        rust-for-linux@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Alex Gaynor <alex.gaynor@...il.com>,
        Alice Ryhl <aliceryhl@...gle.com>,
        Andreas Hindborg <a.hindborg@...sung.com>,
        Benno Lossin <benno.lossin@...ton.me>,
        Björn Roy Baron <bjorn3_gh@...tonmail.com>,
        Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
        Miguel Ojeda <ojeda@...nel.org>,
        Wedson Almeida Filho <wedsonaf@...il.com>
Subject: Re: [PATCH] rust: replace <linux/module.h> with <linux/export.h> in
 rust/exports.c

On 11/24/23 11:26, Masahiro Yamada wrote:
> <linux/export.h> is the right header to include for using
> EXPORT_SYMBOL_GPL. <linux/module.h> includes much more bloat.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> [...]
>   
> -#include <linux/module.h>
> +#include <linux/export.h>
>   
> [...]

I'll use this in my crates patch. Regardless, LGTM.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@...il.com>