linux-kernel - Re: [PATCH v2] fbdev/fsl-diu-fb: Fix srapse warning due to virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <8dfad83f-20b1-49c9-bab8-ff5259ab85d0@gmx.de>
Date:   Sat, 25 Nov 2023 09:57:46 +0100
From:   Helge Deller <deller@....de>
To:     Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
        timur@...nel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fbdev/fsl-diu-fb: Fix srapse warning due to
 virt_to_phys() prototype change

On 11/21/23 01:01, Stanislav Kinsburskii wrote:
> Explicitly cast __iomem pointer to const void* with __force to fix the
> following warning:
>
>     incorrect type in argument 1 (different address spaces)
>        expected void const volatile *address
>        got char [noderef] __iomem *screen_base
>
> Signed-off-by: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311161120.BgyxTBMQ-lkp@intel.com/
> ---
>   drivers/video/fbdev/fsl-diu-fb.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
> index 7fbd9f069ac2..b0fda5bd1964 100644
> --- a/drivers/video/fbdev/fsl-diu-fb.c
> +++ b/drivers/video/fbdev/fsl-diu-fb.c
> @@ -877,7 +877,7 @@ static int map_video_memory(struct fb_info *info)
>   	}
>   	mutex_lock(&info->mm_lock);
>   	info->screen_base = p;
> -	info->fix.smem_start = virt_to_phys(info->screen_base);
> +	info->fix.smem_start = virt_to_phys((__force const void *)info->screen_base);
>   	info->fix.smem_len = smem_len;
>   	mutex_unlock(&info->mm_lock);
>   	info->screen_size = info->fix.smem_len;

applied to fbdev git tree (with some typos corrected).

Helge