linux-kernel - Re: [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for AD7091R-8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231125-pennant-untie-90b5f0828258@spud>
Date:   Sat, 25 Nov 2023 12:21:24 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc:     paul.cercueil@...log.com, Michael.Hennerich@...log.com,
        lars@...afoo.de, jic23@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        marcelo.schmitt1@...il.com, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for
 AD7091R-8

On Thu, Nov 23, 2023 at 01:42:21PM -0300, Marcelo Schmitt wrote:

> +  spi-max-frequency: true

This is not needed, since you have unevaluatedProperties: false &
include the spi periph props.

> +  adi,conversion-start-gpios:
> +    description:

> +      Device tree identifier of the CONVST pin.

"gpio connected to the CONVST pin".

> +      This logic input is used to initiate conversions on the analog
> +      input channels.
> +    maxItems: 1

This looks pretty decent to be overall though.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)