linux-kernel - Re: [PATCH v6 4/8] media: qcom: camss: Move VFE power-domain specifics into vfe.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b30c1ba-9740-41f7-95c0-cdb1803fe19a@linaro.org>
Date:   Sat, 25 Nov 2023 13:54:22 +0100
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        hverkuil-cisco@...all.nl, laurent.pinchart@...asonboard.com,
        Robert Foss <rfoss@...nel.org>,
        Todor Tomov <todor.too@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        matti.lehtimaki@...il.com, quic_grosikop@...cinc.com
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 4/8] media: qcom: camss: Move VFE power-domain
 specifics into vfe.c

On 25.11.2023 13:53, Konrad Dybcio wrote:
> On 23.11.2023 18:03, Bryan O'Donoghue wrote:
>> Moving the location of the hooks to VFE power domains has several
>> advantages.
>>
>> 1. Separation of concerns and functional decomposition.
>>    vfe.c should be responsible for and know best how manage
>>    power-domains for a VFE, excising from camss.c follows this
>>    principle.
>>
>> 2. Embedding a pointer to genpd in struct camss_vfe{} meas that we can
>>    dispense with a bunch of kmalloc array inside of camss.c.
>>
>> 3. Splitting up titan top gdsc from vfe/ife gdsc provides a base for
>>    breaking up magic indexes in dtsi.
>>
>> Suggested-by: Matti Lehtimäki <matti.lehtimaki@...il.com>
>> Tested-by: Matti Lehtimäki <matti.lehtimaki@...il.com>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybciolinaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad