linux-kernel - Re: [net-next RFC PATCH v2 00/11] net: phy: Support DT PHY package

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6562304c.050a0220.44374.e4b3@mx.google.com>
Date:   Sat, 25 Nov 2023 14:50:01 +0100
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@...adcom.com>,
        Daniel Golle <daniel@...rotopia.org>,
        Qingfang Deng <dqfext@...il.com>,
        SkyLake Huang <SkyLake.Huang@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Vladimir Oltean <olteanv@...il.com>,
        David Epping <david.epping@...singlinkelectronics.com>,
        Harini Katakam <harini.katakam@....com>,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Robert Marko <robert.marko@...tura.hr>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [net-next RFC PATCH v2 00/11] net: phy: Support DT PHY package

On Sat, Nov 25, 2023 at 06:28:06PM +0100, Andrew Lunn wrote:
> > One example is this:
> > 
> >         ethernet-phy-package@0 {
> >             #address-cells = <1>;
> >             #size-cells = <0>;
> 
> Please extend this example with a compatible, and include a property
> which is global.
>

Hi, don't know if you notice the changelog, I now check with the node
name prefix instead of using compatible ethernet-phy-package. (some
requested and didn't like using it) (easy to reintroduce, was just a
small proposal/idea)

Also in theory the compatible for specific PHY package can also be
skipped. (we can use the select way and match for PHY id. Can also be
introduced easily but shouldn't that be checked in some way? Or it's ok
to have a compatible that will only be used for documentation?)

> > (For Andrew, we are looking intro making this in at803x PHY driver and see
> > what functions can be reused, idea is to move the driver to a dedicated
> > directory and create something like at803x-common.c as the at803x PHY
> > driver is too bloated and splitting it it's a better approach)
> 
> This sounds good.
> 

Thanks, also for Russell, I forgot to include the PHY mode in the
qca807x commit, will include that once I will move the code to the
shared implementation with at803x. (sorry)

-- 
	Ansuel