linux-kernel - Re: [PATCH 2/2] leds: add mp3326 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202311260403.PyY8h5Dj-lkp@intel.com>
Date:   Sun, 26 Nov 2023 05:05:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Yuxi Wang <Yuxi.Wang@...olithicpower.com>, pavel@....cz,
        lee@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        wyx137120466@...il.com
Subject: Re: [PATCH 2/2] leds: add mp3326 driver

Hi Yuxi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on lee-leds/for-leds-next]
[also build test WARNING on robh/for-next linus/master v6.7-rc2 next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuxi-Wang/dt-bindings-leds-add-mps-mp3326-LED/20231124-173610
base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git for-leds-next
patch link:    https://lore.kernel.org/r/20231124093034.951-3-Yuxi.Wang%40monolithicpower.com
patch subject: [PATCH 2/2] leds: add mp3326 driver
config: x86_64-randconfig-123-20231126 (https://download.01.org/0day-ci/archive/20231126/202311260403.PyY8h5Dj-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231126/202311260403.PyY8h5Dj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311260403.PyY8h5Dj-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/leds/leds-mp3326.c: In function 'mp3326_parse_dt':
   drivers/leds/leds-mp3326.c:543:6: warning: unused variable 'val' [-Wunused-variable]
     int val;
         ^~~
   drivers/leds/leds-mp3326.c: At top level:
   drivers/leds/leds-mp3326.c:611:3: error: 'struct i2c_driver' has no member named 'probe_new'; did you mean 'probe'?
     .probe_new = mp3326_leds_probe,
      ^~~~~~~~~
      probe
>> drivers/leds/leds-mp3326.c:611:15: warning: initialization makes integer from pointer without a cast [-Wint-conversion]
     .probe_new = mp3326_leds_probe,
                  ^~~~~~~~~~~~~~~~~
   drivers/leds/leds-mp3326.c:611:15: note: (near initialization for 'mp3326_driver.class')
   drivers/leds/leds-mp3326.c:611:15: error: initializer element is not computable at load time
   drivers/leds/leds-mp3326.c:611:15: note: (near initialization for 'mp3326_driver.class')


vim +611 drivers/leds/leds-mp3326.c

   609	
   610	static struct i2c_driver mp3326_driver = {
 > 611		.probe_new = mp3326_leds_probe,
   612		.driver = {
   613				.name = "mp3326_led",
   614				.of_match_table = mp3326_of_match,
   615			   },
   616		.id_table = mp3326_id,
   617	};
   618	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki