linux-kernel - Re: [PATCH 1/4] kdump: add crashkernel cma suffix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202311251303.71yrbT6l-lkp@intel.com>
Date:   Sat, 25 Nov 2023 15:24:22 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiri Bohac <jbohac@...e.cz>, Baoquan He <bhe@...hat.com>,
        Vivek Goyal <vgoyal@...hat.com>,
        Dave Young <dyoung@...hat.com>, kexec@...ts.infradead.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        mhocko@...e.cz
Subject: Re: [PATCH 1/4] kdump: add crashkernel cma suffix

Hi Jiri,

kernel test robot noticed the following build warnings:

[auto build test WARNING on powerpc/next]
[also build test WARNING on powerpc/fixes s390/features linus/master v6.7-rc2 next-20231124]
[cannot apply to tip/x86/core arm64/for-next/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiri-Bohac/kdump-implement-reserve_crashkernel_cma/20231125-082724
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
patch link:    https://lore.kernel.org/r/ZWEAPXiCCgAf1WrY%40dwarf.suse.cz
patch subject: [PATCH 1/4] kdump: add crashkernel cma suffix
config: alpha-randconfig-r081-20231125 (https://download.01.org/0day-ci/archive/20231125/202311251303.71yrbT6l-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231125/202311251303.71yrbT6l-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311251303.71yrbT6l-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/crash_core.c: In function 'parse_crashkernel':
>> kernel/crash_core.c:319:28: warning: unused variable 'cma_base' [-Wunused-variable]
     319 |         unsigned long long cma_base;
         |                            ^~~~~~~~


vim +/cma_base +319 kernel/crash_core.c

   302	
   303	/*
   304	 * That function is the entry point for command line parsing and should be
   305	 * called from the arch-specific code.
   306	 *
   307	 * If crashkernel=,high|low is supported on architecture, non-NULL values
   308	 * should be passed to parameters 'low_size' and 'high'.
   309	 */
   310	int __init parse_crashkernel(char *cmdline,
   311				     unsigned long long system_ram,
   312				     unsigned long long *crash_size,
   313				     unsigned long long *crash_base,
   314				     unsigned long long *low_size,
   315				     unsigned long long *cma_size,
   316				     bool *high)
   317	{
   318		int ret;
 > 319		unsigned long long cma_base;
   320	
   321		/* crashkernel=X[@offset] */
   322		ret = __parse_crashkernel(cmdline, system_ram, crash_size,
   323					crash_base, NULL);
   324	#ifdef CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
   325		/*
   326		 * If non-NULL 'high' passed in and no normal crashkernel
   327		 * setting detected, try parsing crashkernel=,high|low.
   328		 */
   329		if (high && ret == -ENOENT) {
   330			ret = __parse_crashkernel(cmdline, 0, crash_size,
   331					crash_base, suffix_tbl[SUFFIX_HIGH]);
   332			if (ret || !*crash_size)
   333				return -EINVAL;
   334	
   335			/*
   336			 * crashkernel=Y,low can be specified or not, but invalid value
   337			 * is not allowed.
   338			 */
   339			ret = __parse_crashkernel(cmdline, 0, low_size,
   340					crash_base, suffix_tbl[SUFFIX_LOW]);
   341			if (ret == -ENOENT) {
   342				*low_size = DEFAULT_CRASH_KERNEL_LOW_SIZE;
   343				ret = 0;
   344			} else if (ret) {
   345				return ret;
   346			}
   347	
   348			*high = true;
   349		}
   350	
   351		/*
   352		* optional CMA reservation
   353		* cma_base is ignored
   354		*/
   355		if (cma_size)
   356			__parse_crashkernel(cmdline, 0, cma_size,
   357				&cma_base, suffix_tbl[SUFFIX_CMA]);
   358	#endif
   359		if (!*crash_size)
   360			ret = -EINVAL;
   361	
   362		return ret;
   363	}
   364	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki