linux-kernel - Re: [PATCH] hwmon: sht3x: read out sensor serial number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93260e2e-a913-4341-9bc5-ef23ee3b396e@roeck-us.net>
Date:   Sat, 25 Nov 2023 15:59:01 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Stefan Gloor <code@...fan-gloor.ch>
Cc:     jdelvare@...e.com, corbet@....net, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: sht3x: read out sensor serial number

On Fri, Nov 24, 2023 at 11:09:31PM +0100, Stefan Gloor wrote:
> Hi Guenter,
> 
> thank you for your comments.
> 
> On Fri, Nov 24, 2023 at 09:34:48AM -0800, Guenter Roeck wrote:
> > I am not going to accept this as sysfs attribute. Please implement
> > using debugfs.
> > 
> I will do this in V2.
> 
> > 
> > Also, the attribute (sysfs or debugfs) should not exist if not supported.
> > Please only provide if supported.
> The driver is currently only compatible with "sht3x" and "sts3x". 
> As only a subset of these support this feature, do you recommend I
> create new additional device IDs, i.e., sts32, sts33 and sht33?
> 

If they have different functionality, they need different IDs.

Guenter

> Best,
> Stefan
> -- 
>