linux-kernel - Re: [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b9e75047-b3c1-47ce-a8c5-703e1adcdc08@linaro.org>
Date:   Sun, 26 Nov 2023 11:40:14 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jonathan Cameron <jic23@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Jishnu Prakash <quic_jprakash@...cinc.com>, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        daniel.lezcano@...aro.org, linus.walleij@...aro.org,
        linux-arm-msm@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        quic_subbaram@...cinc.com, quic_collinsd@...cinc.com,
        quic_amelende@...cinc.com, quic_kamalw@...cinc.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        marijn.suijten@...ainline.org, lars@...afoo.de, luca@...tu.xyz,
        linux-iio@...r.kernel.org, lee@...nel.org, rafael@...nel.org,
        rui.zhang@...el.com, lukasz.luba@....com,
        cros-qcom-dts-watchers@...omium.org, sboyd@...nel.org,
        linux-pm@...r.kernel.org, linux-arm-msm-owner@...r.kernel.org,
        kernel@...cinc.com
Subject: Re: [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to
 iio/adc folder

On 25/11/2023 20:34, Jonathan Cameron wrote:
> On Thu, 16 Nov 2023 17:27:53 +0200
> Dmitry Baryshkov <dmitry.baryshkov@...aro.org> wrote:
> 
>> On Thu, 16 Nov 2023 at 13:44, Krzysztof Kozlowski
>> <krzysztof.kozlowski@...aro.org> wrote:
>>>
>>> On 16/11/2023 04:26, Jishnu Prakash wrote:  
>>>> There are several files containing QCOM ADC macros for channel names
>>>> right now in the include/dt-bindings/iio folder. Since all of these
>>>> are specifically for adc, move the files to the
>>>> include/dt-bindings/iio/adc folder.
>>>>
>>>> Also update all affected devicetree and driver files to fix compilation
>>>> errors seen with this move and update documentation files to fix
>>>> dtbinding check errors for the same.
>>>>
>>>> Signed-off-by: Jishnu Prakash <quic_jprakash@...cinc.com>
>>>> ---
>>>>  .../devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml       | 4 ++--
>>>>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +-
>>>>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml  | 2 +-
>>>>  .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml    | 6 +++---
>>>>  arch/arm64/boot/dts/qcom/pm2250.dtsi                      | 2 +-
>>>>  arch/arm64/boot/dts/qcom/pm6125.dtsi                      | 2 +-  
>>>
>>> NAK, bindings are always separate from the other changes.  
>>
>> In this case I'd even try to appeal :-)
>> They are doing `git mv` and then fixing the failouts. I think this
>> should be fine.
> Agreed.  The only easy way around this would be to put some dummy headers
> that include the new ones in old locations temporary basis then delete them later.
> I'm fine with that if Kryzsztof prefers it that way.  Not too disruptive.

I think Rob acked it, so I am fine.

Best regards,
Krzysztof