linux-kernel - Re: [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 26 Nov 2023 05:48:08 -0500
From:   Gary Rookard <garyrookard@...tmail.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     philipp.g.hortmann@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] staging: rtl8192e: renamed variable nDataRate


Greg KH <gregkh@...uxfoundation.org> writes:

> On Sat, Nov 25, 2023 at 05:34:31PM -0500, Gary Rookard wrote:
>> -u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate)
>> +u16  tx_count_to_data_rate(struct rtllib_device *ieee, u8 n_data_rate)
>
> Why are you keeping the "n"?  It's not needed, right?  Remember, these
> were written in "Hungarian notation" which uses the variable name to
> denote the type of the variable, so "n" means "number" perhaps?  So it
> can be dropped.
>
> thanks,
>
> greg k-h

Okay, will redo.

Regards,
Gary