[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231126-attractor-swampland-b1b95bd1322b@spud>
Date: Sun, 26 Nov 2023 11:36:24 +0000
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Jisheng Zhang <jszhang@...nel.org>,
Emil Renner Berthing <kernel@...il.dk>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: starfive: add Milkv Mars board device tree
On Sun, Nov 26, 2023 at 11:27:20AM +0100, Krzysztof Kozlowski wrote:
> On 26/11/2023 11:00, Jisheng Zhang wrote:
> > + cpus {
>
> Board should not bring new CPU nodes. Override by label instead.
>
>
> > + timebase-frequency = <4000000>;
> > + };
This particular one is widespread, but I am not sure why it is being set
on the board level in any of the individual cases. On the platforms
where I do know where the frequency for this comes from it is set by the
SoC, not the board and so should really be fixed by moving this into
$soc.dtsi. I suspect the same is true for the jh7110 and
timebase-frequency is not a board-level setting and probably needs the
same treatment. Those with more insight into how the clocks on the
jh7110 are routed can hopefully advise us here.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists