linux-kernel - Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Nov 2023 15:30:14 +0100
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Wolfram Sang <wsa@...nel.org>, Jim Cromie <jim.cromie@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare
 I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

Hi Heiner,

in this last patch I will add a couple of minor comments valid
for the previous, as well.

On Fri, Nov 24, 2023 at 11:16:19AM +0100, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
> 
> Series was created supported by Coccinelle and its splitpatch.

this sentence is grammatically incorrect, I guess you meant:

"The series was created with support from Coccinelle and its
splitpatch feature."

Please fix it if you are going to resend it.

> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> 

Just for you to know, all your patches have a blank line after
your SoB, it doesn't really matter as I guess git removes it.

In any case, as before:

Acked-by: Andi Shyti <andi.shyti@...nel.org>                     
                                                                 
and I believe:                                                   
                                                                 
Acked-by: Jim Cromie <jim.cromie@...il.com>                      
                                                                 
so that patchwork takes it.

Thanks,
Andi