linux-kernel - Re: [PATCH] iio: imu: inv_mpu6050: return callee's error code rather than -EINVAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 26 Nov 2023 17:07:00 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Su Hui <suhui@...china.com>
Cc:     lars@...afoo.de, jean-baptiste.maneyrol@....com, chenhuiz@...s.com,
        andy.shevchenko@...il.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: imu: inv_mpu6050: return callee's error code
 rather than -EINVAL

On Mon, 30 Oct 2023 10:07:53 +0800
Su Hui <suhui@...china.com> wrote:

> regmap_bulk_write()/regmap_bulk_read() return zero or negative error
> code, return the callee's error code is better than '-EINVAL'.
Thanks and fully agree - though one small tweak I made whilst applying is mentioned
below.

Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to see if we missed anything.

> 
> Signed-off-by: Su Hui <suhui@...china.com>
> ---
>  drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index a9a5fb266ef1..5ded0781797c 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -572,7 +572,7 @@ static int inv_mpu6050_sensor_set(struct inv_mpu6050_state  *st, int reg,
>  	ind = (axis - IIO_MOD_X) * 2;
>  	result = regmap_bulk_write(st->map, reg + ind, &d, sizeof(d));
>  	if (result)
> -		return -EINVAL;
> +		return result;
>  
>  	return 0;
I tweaked this to go further

	return regmap_bulk_write();

>  }
> @@ -586,7 +586,7 @@ static int inv_mpu6050_sensor_show(struct inv_mpu6050_state  *st, int reg,
>  	ind = (axis - IIO_MOD_X) * 2;
>  	result = regmap_bulk_read(st->map, reg + ind, &d, sizeof(d));
>  	if (result)
> -		return -EINVAL;
> +		return result;
>  	*val = (short)be16_to_cpup(&d);
>  
>  	return IIO_VAL_INT;