linux-kernel - Re: [PATCH] iio: imu: bmi323: Make the local structures static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231126180637.1a832574@jic23-huawei>
Date:   Sun, 26 Nov 2023 18:06:37 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Jagath Jog J <jagathjog1996@...il.com>
Cc:     andriy.shevchenko@...ux.intel.com, oe-kbuild-all@...ts.linux.dev,
        lkp@...el.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: imu: bmi323: Make the local structures static

On Wed,  8 Nov 2023 09:28:31 +0530
Jagath Jog J <jagathjog1996@...il.com> wrote:

> Make the local structures static within their respective driver files.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202311070530.qKhLTz1Y-lkp@intel.com/
> Fixes: b512c767e7bc ("iio: imu: Add driver for BMI323 IMU")
Applied to the togreg branch of iio.git but I dropped this fixes tag because
it's already wrong due to a rebase and that may well happen again.

Probably better to just not have one in this case :(

Jonathan

> Signed-off-by: Jagath Jog J <jagathjog1996@...il.com>
> ---
>  drivers/iio/imu/bmi323/bmi323_i2c.c | 2 +-
>  drivers/iio/imu/bmi323/bmi323_spi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/imu/bmi323/bmi323_i2c.c b/drivers/iio/imu/bmi323/bmi323_i2c.c
> index 0008e186367d..20a8001b9956 100644
> --- a/drivers/iio/imu/bmi323/bmi323_i2c.c
> +++ b/drivers/iio/imu/bmi323/bmi323_i2c.c
> @@ -66,7 +66,7 @@ static struct regmap_bus bmi323_regmap_bus = {
>  	.write = bmi323_regmap_i2c_write,
>  };
>  
> -const struct regmap_config bmi323_i2c_regmap_config = {
> +static const struct regmap_config bmi323_i2c_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 16,
>  	.max_register = BMI323_CFG_RES_REG,
> diff --git a/drivers/iio/imu/bmi323/bmi323_spi.c b/drivers/iio/imu/bmi323/bmi323_spi.c
> index 6dc3352dd714..7b1e8127d0dd 100644
> --- a/drivers/iio/imu/bmi323/bmi323_spi.c
> +++ b/drivers/iio/imu/bmi323/bmi323_spi.c
> @@ -41,7 +41,7 @@ static struct regmap_bus bmi323_regmap_bus = {
>  	.write = bmi323_regmap_spi_write,
>  };
>  
> -const struct regmap_config bmi323_spi_regmap_config = {
> +static const struct regmap_config bmi323_spi_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 16,
>  	.pad_bits = 8,