linux-kernel - Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfuBxw4=Aku32yx3e0zbTCARSo9r1ST71UoaC-Dp3K3_m44jQ@mail.gmail.com>
Date:   Sat, 25 Nov 2023 23:03:35 -0700
From:   jim.cromie@...il.com
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        Andi Shyti <andi.shyti@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare
 I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

On Fri, Nov 24, 2023 at 3:16 AM Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
>

Acked:


> ---
>  drivers/i2c/busses/scx200_acb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
> index 83c1db610..3648382b8 100644
> --- a/drivers/i2c/busses/scx200_acb.c
> +++ b/drivers/i2c/busses/scx200_acb.c
> @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text,
>         snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index);
>         adapter->owner = THIS_MODULE;
>         adapter->algo = &scx200_acb_algorithm;
> -       adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> +       adapter->class = I2C_CLASS_HWMON;
>         adapter->dev.parent = dev;
>
>         mutex_init(&iface->mutex);
>