linux-kernel - Re: [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231127-opposite-haste-4c9049cecf91@spud>
Date:   Mon, 27 Nov 2023 17:42:25 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Ziqi Chen <quic_ziqichen@...cinc.com>
Cc:     quic_asutoshd@...cinc.com, quic_cang@...cinc.com,
        bvanassche@....org, mani@...nel.org, stanley.chu@...iatek.com,
        adrian.hunter@...el.com, beanhuo@...ron.com, avri.altman@....com,
        junwoo80.lee@...sung.com, martin.petersen@...cle.com,
        quic_nguyenb@...cinc.com, quic_nitirawa@...cinc.com,
        linux-scsi@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: ufs: Add msi-parent for UFS MCQ

On Mon, Nov 27, 2023 at 05:40:45PM +0000, Conor Dooley wrote:
> On Mon, Nov 27, 2023 at 01:36:02PM +0800, Ziqi Chen wrote:
> > The Message Signaled Interrupts (MSI) support has been introduced in
> > UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt
> > approach for MCQ. If choose to use MSI, In UFS DT, we need to provide
> > msi-parent property that point to the hardware entity which serves as
> > the MSI controller for this UFS controller.
> > 
> > Signed-off-by: Ziqi Chen <quic_ziqichen@...cinc.com>
> > 
> 
> > V2 -> V3: Wrap commit message to meet Linux coding style.
> > V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to
> >           incorporate the details about when MCQ/MSI got introduced.
> 
> This should be below the --- line FYI. With that fixed,
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Also, you omitted an ack from Krzysztof in
<ae2f2dc9-4c08-4db8-bfae-80608723d8c3@...aro.org>

Cheers,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)