linux-kernel - Re: [PATCH v4 vfio 0/2] vfio/pds: Fixes for locking bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231127110850.3e4f527a.alex.williamson@redhat.com>
Date:   Mon, 27 Nov 2023 11:08:50 -0700
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Brett Creeley <brett.creeley@....com>
Cc:     <jgg@...pe.ca>, <yishaih@...dia.com>,
        <shameerali.kolothum.thodi@...wei.com>, <kevin.tian@...el.com>,
        <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <shannon.nelson@....com>
Subject: Re: [PATCH v4 vfio 0/2] vfio/pds: Fixes for locking bugs

On Wed, 22 Nov 2023 11:25:30 -0800
Brett Creeley <brett.creeley@....com> wrote:

> This series contains fixes for locking bugs in the recently introduced
> pds-vfio-pci driver. There was an initial bug reported by Dan Carpenter
> at:
> 
> https://lore.kernel.org/kvm/1f9bc27b-3de9-4891-9687-ba2820c1b390@moroto.mountain/
> 
> However, more locking bugs were found when looking into the previously
> mentioned issue. So, all fixes are included in this series.
> 
> v4:
> - Drop patch 1/3 since it added a spinlock_init that was later replaced
>   by a mutex_init anyway
> 
> v3:
> https://lore.kernel.org/kvm/20231027223651.36047-1-brett.creeley@amd.com/
> - Change reset lock from spinlock to mutex
> 
> v2:
> https://lore.kernel.org/kvm/20231011230115.35719-1-brett.creeley@amd.com/
> - Trim the OOPs in the patch commit messages
> - Rework patch 3/3 to only unlock the spinlock once
> - Destroy the state_mutex in the driver specific vfio_device_ops.release
>   callback
> 
> v1:
> https://lore.kernel.org/kvm/20230914191540.54946-1-brett.creeley@amd.com/
> 
> Brett Creeley (2):
>   vfio/pds: Fix mutex lock->magic != lock warning
>   vfio/pds: Fix possible sleep while in atomic context
> 
>  drivers/vfio/pci/pds/pci_drv.c  |  4 ++--
>  drivers/vfio/pci/pds/vfio_dev.c | 30 +++++++++++++++++++++---------
>  drivers/vfio/pci/pds/vfio_dev.h |  2 +-
>  3 files changed, 24 insertions(+), 12 deletions(-)
> 

Applied to vfio for-linus branch for v6.7.  Thanks,

Alex