linux-kernel - Re: [PATCH v2] regulator: event: Add regulator netlink event support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABqG17i0cFLoZdU==bkzveKem4wMwYz3eMVE2Y51BHsKEsUXsg@mail.gmail.com>
Date:   Tue, 28 Nov 2023 01:28:38 +0530
From:   Naresh Solanki <naresh.solanki@...ements.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
        Patrick Rudolph <patrick.rudolph@...ements.com>
Subject: Re: [PATCH v2] regulator: event: Add regulator netlink event support

Hi Mark,


On Mon, 27 Nov 2023 at 19:45, Mark Brown <broonie@...nel.org> wrote:
>
> On Mon, Nov 27, 2023 at 04:07:45PM +0530, Naresh Solanki wrote:
> > On Thu, 23 Nov 2023 at 18:27, Mark Brown <broonie@...nel.org> wrote:
>
> > > I'm also not clear on where the 15 byte limit comes from.
>
> > I felt 15 characters would be sufficient for regulator names.
> > Would need your inputs to make sure here.
>
> It does feel like it might be a bit tight - perhaps double it?
Sure. Will change to 32.


Also there is a possibility of regulator name  duplication.
And below mechanism is already used in debugfs:

        const char *rname = rdev_get_name(rdev);
        char name[NAME_MAX];

        /* Avoid duplicate debugfs directory names */
        if (parent && rname == rdev->desc->name) {
                snprintf(name, sizeof(name), "%s-%s", dev_name(parent),
                         rname);
                rname = name;
        }

I need recommendations here.

Regards,
Naresh