linux-kernel - Re: [Nouveau] [PATCH] nouveau/gsp/r535: remove a stray unlock in r535_gsp_rpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c08f93b02df48745342a04a7d3f603f84064a67.camel@nvidia.com>
Date:   Mon, 27 Nov 2023 20:05:18 +0000
From:   Timur Tabi <ttabi@...dia.com>
To:     "kherbst@...hat.com" <kherbst@...hat.com>,
        "dan.carpenter@...aro.org" <dan.carpenter@...aro.org>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
        "airlied@...hat.com" <airlied@...hat.com>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>
Subject: Re: [Nouveau] [PATCH] nouveau/gsp/r535: remove a stray unlock in
 r535_gsp_rpc_send()

On Mon, 2023-11-27 at 15:56 +0300, Dan Carpenter wrote:
> This unlock doesn't belong here and it leads to a double unlock in
> the caller, r535_gsp_rpc_push().
> 
> Fixes: 176fdcbddfd2 ("drm/nouveau/gsp/r535: add support for booting GSP-
> RM")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Nice catch!

Reviewed-by: Timur Tabi <ttabi@...dia.com>