linux-kernel - RE: [PATCH v3 02/13] scsi: fnic: Add and use fnic number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58960721DF0510FC1CED01F8C3BDA@SJ0PR11MB5896.namprd11.prod.outlook.com>
Date:   Mon, 27 Nov 2023 20:17:53 +0000
From:   "Karan Tilak Kumar (kartilak)" <kartilak@...co.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     "Sesidhar Baddela (sebaddel)" <sebaddel@...co.com>,
        "Arulprabhu Ponnusamy (arulponn)" <arulponn@...co.com>,
        "Dhanraj Jhawar (djhawar)" <djhawar@...co.com>,
        "Gian Carlo Boffa (gcboffa)" <gcboffa@...co.com>,
        "Masa Kai (mkai2)" <mkai2@...co.com>,
        "Satish Kharat (satishkh)" <satishkh@...co.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 02/13] scsi: fnic: Add and use fnic number

On Friday, November 24, 2023 5:22 PM, Martin K. Petersen <martin.petersen@...cle.com> wrote:
>
>
> Hi Karan,
>
> > Add fnic_num in fnic.h to identify fnic in a multi-fnic environment.
> > Increment and set the fnic number during driver load in fnic_probe.
> > Replace the host number with fnic number in debugfs.
>
> I agree with Hannes. Everything else in the stack will be using the host number. Your change will make it harder to correlate a SCSI error message to an fnic driver instance.
>
> If you absolutely need an instance number I suggest you add it as an orthogonal value instead replacing the host. Also, we typically use an idr for enumerating things like this.
>

Thanks for your review and comments, Martin.

I understand the issue. I'll take your suggestion about adding the fnic instance number as an orthogonal value instead of replacing the host number.
Could you please help me understand what is meant by "idr"? How can I use it?

Regards,
Karan