linux-kernel - RE: [EXT] Re: [PATCH net-next v2 2/2] octeon_ep: get max rx packet length from firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR18MB4734C1F52388E5238C7F8D40C7BDA@PH0PR18MB4734.namprd18.prod.outlook.com>
Date:   Mon, 27 Nov 2023 04:43:41 +0000
From:   Shinas Rasheed <srasheed@...vell.com>
To:     Simon Horman <horms@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Haseeb Gani <hgani@...vell.com>,
        Vimlesh Kumar <vimleshk@...vell.com>,
        "egallen@...hat.com" <egallen@...hat.com>,
        "mschmidt@...hat.com" <mschmidt@...hat.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "wizhao@...hat.com" <wizhao@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        "jesse.brandeburg@...el.com" <jesse.brandeburg@...el.com>,
        Suman Ghosh <sumang@...vell.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Sathesh B Edara <sedara@...vell.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: RE: [EXT] Re: [PATCH net-next v2 2/2] octeon_ep: get max rx packet
 length from firmware


Hi Simon,

> -----Original Message-----
> From: Simon Horman <horms@...nel.org>
> Sent: Friday, November 24, 2023 10:38 PM
> To: Shinas Rasheed <srasheed@...vell.com>
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Haseeb Gani
> <hgani@...vell.com>; Vimlesh Kumar <vimleshk@...vell.com>;
> egallen@...hat.com; mschmidt@...hat.com; pabeni@...hat.com;
> kuba@...nel.org; davem@...emloft.net; wizhao@...hat.com;
> konguyen@...hat.com; jesse.brandeburg@...el.com; Suman Ghosh
> <sumang@...vell.com>; Veerasenareddy Burru <vburru@...vell.com>;
> Sathesh B Edara <sedara@...vell.com>; Eric Dumazet
> <edumazet@...gle.com>
> Subject: [EXT] Re: [PATCH net-next v2 2/2] octeon_ep: get max rx packet
> length from firmware
> > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > index 2da00a701df2..423eec5ff3ad 100644
> > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> > @@ -1377,8 +1378,15 @@ static int octep_probe(struct pci_dev *pdev,
> const struct pci_device_id *ent)
> >
> >  	netdev->hw_features = NETIF_F_SG;
> >  	netdev->features |= netdev->hw_features;
> > +
> > +	max_rx_pktlen = octep_ctrl_net_get_mtu(octep_dev,
> OCTEP_CTRL_NET_INVALID_VFID);
> > +	if (max_rx_pktlen < 0) {
> > +		dev_err(&octep_dev->pdev->dev,
> > +			"Failed to get max receive packet size; err = %d\n",
> max_rx_pktlen);
> > +		goto register_dev_err;
> 
> Hi Shinas,
> 
> This jump will cause this function to return err.  But err is 0 here.
> Perhaps it should be set to a negative error value instead?

Yes I think that was a slight erroneous oversight. I see that this patch has been accepted. I shall commit a fix for the same after review in the net branch doing the same.