linux-kernel - Re: [PATCH] scsi: be2iscsi: fix a memleak in beiscsi_init_wrb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Nov 2023 15:26:38 -0600
From:   Mike Christie <michael.christie@...cle.com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     Ketan Mukadam <ketan.mukadam@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        John Soni Jose <sony.john-n@...lex.com>,
        Jayamohan Kallickal <jayamohank@...il.com>,
        James Bottomley <JBottomley@...allels.com>,
        Mike Christie <michaelc@...wisc.edu>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: be2iscsi: fix a memleak in beiscsi_init_wrb_handle

On 11/23/23 2:19 AM, Dinghao Liu wrote:
> When an error occurs in the for loop of beiscsi_init_wrb_handle(),
> we should free phwi_ctxt->be_wrbq before returning an error code
> to prevent potential memleak.
> 
> Fixes: a7909b396ba7 ("[SCSI] be2iscsi: Fix dynamic CID allocation Mechanism in driver")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
>  drivers/scsi/be2iscsi/be_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index e48f14ad6dfd..06acb5ff609e 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -2710,6 +2710,7 @@ static int beiscsi_init_wrb_handle(struct beiscsi_hba *phba)
>  		kfree(pwrb_context->pwrb_handle_base);
>  		kfree(pwrb_context->pwrb_handle_basestd);
>  	}
> +	kfree(phwi_ctxt->be_wrbq);
>  	return -ENOMEM;
>  }
>  

Reviewed-by: Mike Christie <michael.christie@...cle.com>