linux-kernel - Re: [PATCH v2 1/2] driver core: Export device_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbZvUMy7PzqnPSsM+SmMv5Z0mnVq_GU9_9HbBWXkg21zA@mail.gmail.com>
Date:   Mon, 27 Nov 2023 23:34:00 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>, Liu Ying <victor.liu@....com>
Cc:     Maxime Ripard <mripard@...nel.org>, rafael@...nel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-next@...r.kernel.org, sfr@...b.auug.org.au,
        andrzej.hajda@...el.com, neil.armstrong@...aro.org,
        rfoss@...nel.org, Laurent.pinchart@...asonboard.com,
        jonas@...boo.se, jernej.skrabec@...il.com,
        maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
        airlied@...il.com, daniel@...ll.ch,
        angelogioacchino.delregno@...labora.com, ulf.hansson@...aro.org
Subject: Re: [PATCH v2 1/2] driver core: Export device_is_dependent() to modules

On Mon, Nov 27, 2023 at 7:20 PM Greg KH <gregkh@...uxfoundation.org> wrote:

[Maxime]
> > So, a committer just applied this to drm-misc-fixes without your
> > approval.

That was me, mea culpa.
I learned a lesson. Or two.

> Wait, why exactly is this needed?  Nothing outside of the driver core
> should be needing this function, it shouldn't be public at all (I missed
> that before.)
>
> So please, revert it for now, let's figure out why DRM thinks this is
> needed for it's devices, and yet no other bus/subsystem does.

I'm preparing a revert series back to the original patch causing
the issue so we can clear the original bug out of the way, take
a step back and fix this properly.

Yours,
Linus Walleij