linux-kernel - Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for StarFive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07fc5ebe-47b2-4843-ad49-36e6686e5a9a@kernel.org>
Date:   Mon, 27 Nov 2023 09:49:05 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Sia Jee Heng <jeeheng.sia@...rfivetech.com>,
        paul.walmsley@...ive.com, palmer@...belt.com,
        aou@...s.berkeley.edu, conor@...nel.org, kernel@...il.dk,
        robh+dt@...nel.org, emil.renner.berthing@...onical.com
Cc:     linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        leyfoon.tan@...rfivetech.com
Subject: Re: [PATCH 6/7] serial: xilinx_uartps: Add new compatible string for
 StarFive

On 27/11/2023 02:36, Sia Jee Heng wrote:
> This patch adds the new compatible string for StarFive JH8100 SoC
> 
> Signed-off-by: Sia Jee Heng <jeeheng.sia@...rfivetech.com>
> Reviewed-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> ---
>  drivers/tty/serial/xilinx_uartps.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 66a45a634158..170901c143c2 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1210,7 +1210,7 @@ OF_EARLYCON_DECLARE(cdns, "xlnx,xuartps", cdns_early_console_setup);
>  OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p8", cdns_early_console_setup);
>  OF_EARLYCON_DECLARE(cdns, "cdns,uart-r1p12", cdns_early_console_setup);
>  OF_EARLYCON_DECLARE(cdns, "xlnx,zynqmp-uart", cdns_early_console_setup);
> -
> +OF_EARLYCON_DECLARE(cdns, "starfive,jh8100-uart", cdns_early_console_setup);
>  
>  /* Static pointer to console port */
>  static struct uart_port *console_port;
> @@ -1448,6 +1448,7 @@ static const struct of_device_id cdns_uart_of_match[] = {
>  	{ .compatible = "cdns,uart-r1p8", },
>  	{ .compatible = "cdns,uart-r1p12", .data = &zynqmp_uart_def },
>  	{ .compatible = "xlnx,zynqmp-uart", .data = &zynqmp_uart_def },
> +	{ .compatible = "starfive,jh8100-uart", },

Why you do not express compatibility in your bindings? Skip this driver
change.

Best regards,
Krzysztof