linux-kernel - Re: [PATCH v2] mfd: intel-lpss: Add missing check for platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231127085356.GD1470173@google.com>
Date:   Mon, 27 Nov 2023 08:53:56 +0000
From:   Lee Jones <lee@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Jiasheng Jiang <jiasheng@...as.ac.cn>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: intel-lpss: Add missing check for
 platform_get_resource

On Fri, 24 Nov 2023, Andy Shevchenko wrote:

> On Fri, Jun 09, 2023 at 09:48:18AM +0800, Jiasheng Jiang wrote:
> > Add the missing check for platform_get_resource and return error
> > if it fails.
> 
> > Fixes: 4b45efe85263 ("mfd: Add support for Intel Sunrisepoint LPSS devices")
> 
> This does not fix anything and just introduces a duplication code.
> I would like this to be reverted. Should I send one?

Checking this value at the source of obtention and providing and earlier
return with arguably a better return value, all at the cost of an
inexpensive pointer comparison to NULL doesn't sound like a terrible
idea.

If you were committed to the idea of removing it, which I suggest you
reconsider, I would insist that you replace it with at least a comment.

-- 
Lee Jones [李琼斯]