[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZWRwPJQA_wNEVD8Y@kekkonen.localdomain>
Date: Mon, 27 Nov 2023 10:32:28 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Alain Volmat <alain.volmat@...s.st.com>
Cc: Hugues Fruchet <hugues.fruchet@...s.st.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Russell King <linux@...linux.org.uk>,
Philipp Zabel <p.zabel@...gutronix.de>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Dan Scally <dan.scally@...asonboard.com>,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 3/5] media: stm32-dcmipp: STM32 DCMIPP camera
interface driver
Hi Alain,
On Wed, Nov 22, 2023 at 08:39:17AM +0100, Alain Volmat wrote:
> From: Hugues Fruchet <hugues.fruchet@...s.st.com>
>
> This V4L2 subdev driver enables Digital Camera Memory Interface
> Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
>
> Signed-off-by: Hugues Fruchet <hugues.fruchet@...s.st.com>
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>
One more thing. I think you're missing all the link_validate ops, meaning
it's possible to start the hardware with invalid configuration.
Could you add them? It can be a separate patch. I'll postpone these until
that.
--
Regards,
Sakari Ailus
Powered by blists - more mailing lists