[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87bkbfzddr.fsf@igel.home>
Date: Mon, 27 Nov 2023 11:42:08 +0100
From: Andreas Schwab <schwab@...ux-m68k.org>
To: Charlie Jenkins <charlie@...osinc.com>
Cc: Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>, Ron Economos <re@...z.net>,
Samuel Holland <samuel.holland@...ive.com>,
linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] riscv: Safely remove entries from relocation list
On Nov 22 2023, Charlie Jenkins wrote:
> @@ -683,17 +700,29 @@ int add_relocation_to_accumulate(struct module *me, int type, void *location,
>
> if (!found) {
> rel_head = kmalloc(sizeof(*rel_head), GFP_KERNEL);
> +
> + if (!rel_head)
> + return -ENOMEM;
> +
> rel_head->rel_entry =
> kmalloc(sizeof(struct list_head), GFP_KERNEL);
> +
> + if (!rel_head->rel_entry)
> + return -ENOMEM;
This leaks rel_head on error.
--
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
Powered by blists - more mailing lists