linux-kernel - Re: [PATCH] thunderbolt:debugfs:Fix memory leak with using debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231127105914.GL1074920@black.fi.intel.com>
Date:   Mon, 27 Nov 2023 12:59:14 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Yaxiong Tian <iambestgod@...look.com>
Cc:     michael.jamet@...el.com, gregkh@...uxfoundation.org,
        andreas.noever@...il.com, YehezkelShB@...il.com,
        tianyaxiong@...inos.cn, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt:debugfs:Fix memory leak with using
 debugfs_lookup()

On Wed, Nov 22, 2023 at 04:02:43PM +0800, Yaxiong Tian wrote:
> From: Yaxiong Tian <tianyaxiong@...inos.cn>
> 
> As Greg said,When calling debugfs_lookup() the result must have dput()
> called on it,otherwise the memory will leak over time.
> So just call debugfs_lookup_and_remove() instead.
> 
> Fixes: d0f1e0c2a699 ("thunderbolt: Add support for receiver lane margining")
> Signed-off-by: Yaxiong Tian <tianyaxiong@...inos.cn>

Slightly modified the commit log and applied to thunderbolt.git/fixes, thanks!