linux-kernel - Re: [PATCH 1/3] usb: misc: onboard_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <18b2ad8e-6b06-407a-a141-91a90ee7cffd@kontron.de>
Date:   Mon, 27 Nov 2023 12:23:36 +0100
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Frieder Schrempf <frieder@...s.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
        Matthias Kaehlcke <mka@...omium.org>
Cc:     Alexander Stein <alexander.stein@...tq-group.com>,
        Anand Moon <linux.amoon@...il.com>,
        Benjamin Bara <benjamin.bara@...data.com>,
        Rob Herring <robh@...nel.org>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH 1/3] usb: misc: onboard_usb_hub: Print symbolic error
 names

Sorry, forgot to add the correct version prefix v2 in this series. I
will resend.

On 27.11.23 12:13, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
> 
> Instead of printing the decimal error codes, let's use the more
> human-readable symbolic error names provided by the %pe printk
> format specifier.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> ---
> Changes in v2:
> * new patch
> ---
>  drivers/usb/misc/onboard_usb_hub.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c
> index a341b2fbb7b44..077824beffa01 100644
> --- a/drivers/usb/misc/onboard_usb_hub.c
> +++ b/drivers/usb/misc/onboard_usb_hub.c
> @@ -7,6 +7,7 @@
>  
>  #include <linux/device.h>
>  #include <linux/export.h>
> +#include <linux/err.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/init.h>
>  #include <linux/kernel.h>
> @@ -68,7 +69,7 @@ static int onboard_hub_power_on(struct onboard_hub *hub)
>  
>  	err = regulator_bulk_enable(hub->pdata->num_supplies, hub->supplies);
>  	if (err) {
> -		dev_err(hub->dev, "failed to enable supplies: %d\n", err);
> +		dev_err(hub->dev, "failed to enable supplies: %pe\n", ERR_PTR(err));
>  		return err;
>  	}
>  
> @@ -88,7 +89,7 @@ static int onboard_hub_power_off(struct onboard_hub *hub)
>  
>  	err = regulator_bulk_disable(hub->pdata->num_supplies, hub->supplies);
>  	if (err) {
> -		dev_err(hub->dev, "failed to disable supplies: %d\n", err);
> +		dev_err(hub->dev, "failed to disable supplies: %pe\n", ERR_PTR(err));
>  		return err;
>  	}
>  
> @@ -235,7 +236,7 @@ static void onboard_hub_attach_usb_driver(struct work_struct *work)
>  
>  	err = driver_attach(&onboard_hub_usbdev_driver.drvwrap.driver);
>  	if (err)
> -		pr_err("Failed to attach USB driver: %d\n", err);
> +		pr_err("Failed to attach USB driver: %pe\n", ERR_PTR(err));
>  }
>  
>  static int onboard_hub_probe(struct platform_device *pdev)
> @@ -262,7 +263,7 @@ static int onboard_hub_probe(struct platform_device *pdev)
>  
>  	err = devm_regulator_bulk_get(dev, hub->pdata->num_supplies, hub->supplies);
>  	if (err) {
> -		dev_err(dev, "Failed to get regulator supplies: %d\n", err);
> +		dev_err(dev, "Failed to get regulator supplies: %pe\n", ERR_PTR(err));
>  		return err;
>  	}
>