linux-kernel - Re: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231127135008.GN5169@atomide.com>
Date:   Mon, 27 Nov 2023 15:50:08 +0200
From:   Tony Lindgren <tony@...mide.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Andreas Kemnade <andreas@...nade.info>, marcel@...tmann.org,
        johan.hedberg@...il.com, luiz.dentz@...il.com, johan@...nel.org,
        arnd@...db.de, linux-bluetooth@...r.kernel.org,
        linux-kernel@...r.kernel.org, tomi.valkeinen@...asonboard.com,
        Péter Ujfalusi <peter.ujfalusi@...il.com>,
        robh@...nel.org
Subject: Re: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit

* Greg KH <gregkh@...uxfoundation.org> [231127 08:25]:
> On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote:
> > The TI-ST driver seems not to be used anymore. For bluetooth needs
> > there is hci_ll.c which has device tree support and can work without
> > this one. Also firmware download support is there, so it is also not needed
> > here. GPS can also reuse parts of the framework in hci_ll
> > 
> > Contrary from this driver, device tree support has been removed.
> > 
> > So start deorbiting it by marking it as broken.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > ---
> >  drivers/misc/ti-st/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
> > index 1503a6496f632..6bf9cc845745c 100644
> > --- a/drivers/misc/ti-st/Kconfig
> > +++ b/drivers/misc/ti-st/Kconfig
> > @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline"
> >  config TI_ST
> >  	tristate "Shared transport core driver"
> >  	depends on NET && TTY
> > -	depends on GPIOLIB || COMPILE_TEST
> > +	depends on GPIOLIB || COMPILE_TEST || BROKEN
> 
> Why not just delete it?  Why have it stick around any longer?

Sounds good to me too.

Regards,

Tony