linux-kernel - Re: [PATCH 1/1] usb: cdns3: skip set TRB_IOC when usb_request: no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZWS1ucR7dXs153R1@lizhi-Precision-Tower-5810>
Date:   Mon, 27 Nov 2023 10:28:57 -0500
From:   Frank Li <Frank.li@....com>
To:     Peter Chen <peter.chen@...nel.org>, gregkh@...uxfoundation.org
Cc:     imx@...ts.linux.dev, Pawel Laszczak <pawell@...ence.com>,
        Roger Quadros <rogerq@...nel.org>,
        Aswath Govindraju <a-govindraju@...com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:CADENCE USB3 DRD IP DRIVER" <linux-usb@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] usb: cdns3: skip set TRB_IOC when usb_request:
 no_interrupt is true

On Tue, Oct 31, 2023 at 04:45:21PM +0800, Peter Chen wrote:
> On 23-10-27 14:39:19, Frank Li wrote:
> > No completion irq is needed if no_interrupt is true. Needn't set TRB_IOC
> > at this case.
> > 
> > Check usb_request: no_interrupt and set/skip TRB_IOC in
> > cdns3_ep_run_transfer().
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> 
> Acked-by: Peter Chen <peter.chen@...nel.org>

@Greg:
	ping

Frank

> 
> Peter
> > ---
> >  drivers/usb/cdns3/cdns3-gadget.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> > index 69a44bd7e5d02..cd08897f8da8b 100644
> > --- a/drivers/usb/cdns3/cdns3-gadget.c
> > +++ b/drivers/usb/cdns3/cdns3-gadget.c
> > @@ -1124,6 +1124,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
> >  	u16 total_tdl = 0;
> >  	struct scatterlist *s = NULL;
> >  	bool sg_supported = !!(request->num_mapped_sgs);
> > +	u32 ioc = request->no_interrupt ? 0 : TRB_IOC;
> >  
> >  	if (priv_ep->type == USB_ENDPOINT_XFER_ISOC)
> >  		num_trb = priv_ep->interval;
> > @@ -1233,11 +1234,11 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
> >  			control |= pcs;
> >  
> >  		if (priv_ep->type == USB_ENDPOINT_XFER_ISOC  && !priv_ep->dir) {
> > -			control |= TRB_IOC | TRB_ISP;
> > +			control |= ioc | TRB_ISP;
> >  		} else {
> >  			/* for last element in TD or in SG list */
> >  			if (sg_iter == (num_trb - 1) && sg_iter != 0)
> > -				control |= pcs | TRB_IOC | TRB_ISP;
> > +				control |= pcs | ioc | TRB_ISP;
> >  		}
> >  
> >  		if (sg_iter)
> > @@ -1268,7 +1269,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
> >  	priv_req->num_of_trb = num_trb;
> >  
> >  	if (sg_iter == 1)
> > -		trb->control |= cpu_to_le32(TRB_IOC | TRB_ISP);
> > +		trb->control |= cpu_to_le32(ioc | TRB_ISP);
> >  
> >  	if (priv_dev->dev_ver < DEV_VER_V2 &&
> >  	    (priv_ep->flags & EP_TDLCHK_EN)) {
> > -- 
> > 2.34.1
> > 
> 
> -- 
> 
> Thanks,
> Peter Chen