linux-kernel - Re: [PATCH] drm/bridge: panel: Check device dependency before managing device link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZG+8KPWGNcp1jGXnSodXqS0qXiwXDPqf1yqoDZw1aS8w@mail.gmail.com>
Date:   Mon, 27 Nov 2023 17:08:40 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:     Liu Ying <victor.liu@....com>, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, mripard@...nel.org,
        neil.armstrong@...aro.org, ulf.hansson@...aro.org,
        rfoss@...nel.org, tzimmermann@...e.de, jonas@...boo.se,
        jernej.skrabec@...il.com, Laurent.pinchart@...asonboard.com,
        andrzej.hajda@...el.com, angelogioacchino.delregno@...labora.com
Subject: Re: [PATCH] drm/bridge: panel: Check device dependency before
 managing device link

On Mon, Nov 27, 2023 at 2:36 PM Ville Syrjälä
<ville.syrjala@...ux.intel.com> wrote:

> > +     panel_bridge->is_independent = !device_is_dependent(drm_dev->dev,
> > +                                                         panel->dev);
>
> This broke the build. Looks like device_is_dependent() is not even exported.
> ERROR: modpost: "device_is_dependent" [drivers/gpu/drm/drm_kms_helper.ko] undefined!

Yep Ying made a fix, I just applied and pushed it because it was obviously
correct.

> The recommended defconfigs in rerere-cache do seem to have CONFIG_DRM_KMS_HELPER=m
> so this should have been caught before pushing. How did it slip through?

My neglect.

Neglect may have something to do with my desktop being 10 years+
old. Building random defconfigs on this machine takes so long time
that invariably other stuff has been pushed to the branch before
the compiles even complete.

Yeah I know. I should buy a better computer.

Yours,
Linus Walleij