[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZWS80c/ZQvaGIM96@xhacker>
Date: Mon, 27 Nov 2023 23:59:13 +0800
From: Jisheng Zhang <jszhang@...nel.org>
To: Lee Jones <lee@...nel.org>
Cc: Pavel Machek <pavel@....cz>, linux-leds@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: Expand led_colors[] array
On Thu, Nov 23, 2023 at 10:56:20AM +0000, Lee Jones wrote:
> On Mon, 30 Oct 2023, Jisheng Zhang wrote:
>
> > commit 472d7b9e8141 ("dt-bindings: leds: Expand LED_COLOR_ID
> > definitions") expands LED_COLOR_ID definitions for dt-binding. However,
> > it doesn't expand the led_colors[] array in leds core, so if any of
> > the newly expaned LED_COLOR_ID definitions is used, the sysfs will
> > emit null in the led's name color part. Let's expand the led_colors[]
> > array too.
> >
> > Before the commit:
> > /sys/class/leds # ls
> > (null):indicator-0
> >
> > After the commit:
> > /sys/class/leds # ls
> > orange:indicator-0
> >
> > Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> > ---
> > drivers/leds/led-core.c | 5 +++++
> > 1 file changed, 5 insertions(+)
>
> This already exists as:
>
> a067943129b4e leds: core: Add more colors from DT bindings to led_colors
well, my patch was sent earlier than this one... When I sent out the
patch there's neither fix in mailist nor in your repo.
Powered by blists - more mailing lists