linux-kernel - Re: [PATCH v2 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0977ffcd30973d0edc1ae4132216b094.mripard@kernel.org>
Date:   Tue, 28 Nov 2023 14:53:37 +0000
From:   "Maxime Ripard" <mripard@...nel.org>
To:     "David Gow" <davidgow@...gle.com>
Cc:     dlatypov@...gle.com, kunit-dev@...glegroups.com,
        linux-hardening@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, llvm@...ts.linux.dev,
        "Benjamin Berg" <benjamin.berg@...el.com>,
        "Brendan Higgins" <brendan.higgins@...ux.dev>,
        "Kees Cook" <keescook@...omium.org>,
        "Maxime Ripard" <mripard@...nel.org>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Rae Moar" <rmoar@...gle.com>,
        "Richard Fitzgerald" <rf@...nsource.cirrus.com>,
        "Tom Rix" <trix@...hat.com>
Subject: Re: [PATCH v2 3/3] drm/vc4: tests: Use KUNIT_DEFINE_ACTION_WRAPPER

On Tue, 28 Nov 2023 15:24:07 +0800, David Gow wrote:
> In order to pass functions to kunit_add_action(), they need to be of the
> kunit_action_t type. While casting the function pointer can work, it
> will break control-flow integrity.
> 
> vc4_mock already defines such a wrapper for drm_dev_unregister(), but it
> 
> [ ... ]

Reviewed-by: Maxime Ripard <mripard@...nel.org>

Thanks!
Maxime