linux-kernel - Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2148a67f-bd4f-432e-aa0d-c914a4bd5e0d@app.fastmail.com>
Date:   Tue, 28 Nov 2023 15:46:37 +0000
From:   "Jiaxun Yang" <jiaxun.yang@...goat.com>
To:     "Serge Semin" <fancer.lancer@...il.com>
Cc:     "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Arnd Bergmann" <arnd@...db.de>,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Mike Rapoport" <rppt@...nel.org>,
        "Matthew Wilcox" <willy@...radead.org>,
        "Tiezhu Yang" <yangtiezhu@...ngson.cn>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Yinglu Yang" <yangyinglu@...ngson.cn>,
        "Alexey Malahov" <Alexey.Malahov@...kalelectronics.ru>,
        "Aleksandar Rikalo" <aleksandar.rikalo@...mia.com>,
        "Aleksandar Rikalo" <arikalo@...il.com>,
        "Dragan Mladjenovic" <dragan.mladjenovic@...mia.com>,
        "Chao-ying Fu" <cfu@...ecomp.com>, "Marc Zyngier" <maz@...nel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] mips: dmi: Fix early remap on MIPS32



在2023年11月28日十一月 上午11:34，Serge Semin写道：
> On Mon, Nov 27, 2023 at 09:08:11PM +0000, Jiaxun Yang wrote:
[...]
>
> Indeed. Thanks for pointing that out. In the last days several times I
> was looking at that line and for some reason UNCAC_BASE seemed as
> CAC_BASE to me.) Based on what both IO_BASE and UNCAC_BASE are defined
> as of the uncached region anyway, then it should be safe for any
> currently supported MIPS64 (including the Loongson's) to use ioremap()
> in place of dmi_early_remap(). So basically my current patch in the
> subject won't change the method semantics. Let's not to try to fix a
> problem which doesn't exist then, and keep the patch as is especially
> seeing that the alternatives might still cause some troubles. Will you
> be ok with that?

I'd say the safest option is to use CKSEG0 or TO_CAC here, but I'm fine
with ioremap as long as the semantic remains uncached on Loongson.

Thanks.
>
> -Serge(y)
>
>> 
[...]
-- 
- Jiaxun