linux-kernel - Re: [PATCH RESEND] x86/Kconfig: Remove obsolete config X86_32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c5b659bf-0163-45c5-ac88-f1ef876ab3f3@infradead.org>
Date:   Tue, 28 Nov 2023 08:28:11 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Cc:     "H . Peter Anvin" <hpa@...or.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] x86/Kconfig: Remove obsolete config X86_32_SMP



On 11/28/23 01:00, Lukas Bulwahn wrote:
> Commit 0f08c3b22996 ("x86/smp: Reduce code duplication") removes the only
> use of CONFIG_X86_32_SMP.
> 
> Remove the obsolete config X86_32_SMP.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> 
> I sent this cleanup patch in March 2023 and it did not get any attention:
> 
> https://lore.kernel.org/lkml/20230317101621.14413-1-lukas.bulwahn@gmail.com/
> 
> It is just minor cleanup, but it also should not cause any issue.
> This can be quickly checked with grep "X86_32_SMP" . -R and seeing that
> this is only mentioned in arch/x86/Kconfig in this one definition.
> 
> No change here other than rebasing the original patch.
> 
>  arch/x86/Kconfig | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 21890efbfdd8..d7d1ef3d2684 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -384,10 +384,6 @@ config HAVE_INTEL_TXT
>  	def_bool y
>  	depends on INTEL_IOMMU && ACPI
>  
> -config X86_32_SMP
> -	def_bool y
> -	depends on X86_32 && SMP
> -
>  config X86_64_SMP
>  	def_bool y
>  	depends on X86_64 && SMP

-- 
~Randy