linux-kernel - Re: [PATCH 0/2] freezer,sched: do not restore saved

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231128175414.GD3818@noisy.programming.kicks-ass.net>
Date:   Tue, 28 Nov 2023 18:54:14 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Elliot Berman <quic_eberman@...cinc.com>
Cc:     "Aiqun(Maria) Yu" <quic_aiquny@...cinc.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Ingo Molnar <mingo@...nel.org>,
        linux-arm-msm@...r.kernel.org,
        Pavan Kondeti <quic_pkondeti@...cinc.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abhijeet Dharmapurikar <quic_adharmap@...cinc.com>
Subject: Re: [PATCH 0/2] freezer,sched: do not restore saved_state of a
 thawed task

On Tue, Nov 28, 2023 at 11:33:23AM -0600, Elliot Berman wrote:
> 
> 
> On 11/28/2023 11:31 AM, Peter Zijlstra wrote:
> > On Tue, Nov 28, 2023 at 05:12:00PM +0800, Aiqun(Maria) Yu wrote:
> >> On 11/21/2023 1:36 AM, Elliot Berman wrote:
> >>> This series applies couple fixes to commit 8f0eed4a78a8 ("freezer,sched:
> >>> Use saved_state to reduce some spurious wakeups") which was found while
> >>> testing with legacy cgroup freezer. My original testing was only with
> >>> system-wide freezer. We found that thaw_task could be called on a task
> >>> which was already frozen. Prior to commit 8f0eed4a78a8 ("freezer,sched:
> >>> Use saved_state to reduce some spurious wakeups"), this wasn't an issue
> >>> as kernel would try to wake up TASK_FROZEN, which wouldn't match the
> >>> thawed task state, and no harm done to task. After commit 8f0eed4a78a8
> >>> ("freezer,sched: Use saved_state to reduce some spurious wakeups"), it
> >>> was possible to overwrite the state of thawed task.
> >>>
> >>> To: Rafael J. Wysocki <rafael@...nel.org>
> >>> To: Pavel Machek <pavel@....cz>
> >>> To: Ingo Molnar <mingo@...nel.org>
> >>> To: Peter Zijlstra (Intel) <peterz@...radead.org>
> >>> Cc:  <linux-arm-msm@...r.kernel.org>
> >>> Cc: Pavan Kondeti <quic_pkondeti@...cinc.com>
> >>> Cc: Aiqun Yu (Maria) <quic_aiquny@...cinc.com>
> >>> Cc:  <linux-pm@...r.kernel.org>
> >>> Cc:  <linux-kernel@...r.kernel.org>
> >>> Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
> >> Shall we add Fixed tag and Cc: stable@...r.kernel.org ?
> >> Since it is fixing a stable user thread hung issue.
> > 
> > If you want this routed through urgent, then yes.
> 
> Fixes tag is added to https://lore.kernel.org/all/20231120-freezer-state-multiple-thaws-v1-1-f2e1dd7ce5a2@quicinc.com/
> 
> Is CC'ing stable what triggers routing through urgent?

Fixes tag should be enough, lemme go find that other copy then.. so much
email :/