linux-kernel - RE: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for google,spherion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN8PR13MB2738FFDE8693A90B781CCADDFDBCA@BN8PR13MB2738.namprd13.prod.outlook.com>
Date:   Tue, 28 Nov 2023 18:33:52 +0000
From:   "Bird, Tim" <Tim.Bird@...y.com>
To:     Christopher Obbard <chris.obbard@...labora.com>,
        Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Shuah Khan <shuah@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>
CC:     Saravana Kannan <saravanak@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        "kernelci@...ts.linux.dev" <kernelci@...ts.linux.dev>,
        David Gow <davidgow@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "kernel@...labora.com" <kernel@...labora.com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Doug Anderson <dianders@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC PATCH v2 2/2] kselftest: devices: Add sample board file for
 google,spherion



> -----Original Message-----
> From: Christopher Obbard <chris.obbard@...labora.com>
> Hi Nícolas,
> 
> On Mon, 2023-11-27 at 18:34 -0500, Nícolas F. R. A. Prado wrote:
> > Add a sample board file describing the file's format and with the list
> > of devices expected to be probed on the google,spherion machine as an
> > example.
> 
> Did you consider using some machine-readable & extensible format like yaml?
> Surely we don't need to invent yet-another file-format? :-)

I went back to examine the test more closely.  These board files are loaded via
the shell's 'source' command.

If I'm reading the test correctly, the format is machine-readable and extensible, since
it's a fragment of a shell script.  The 'usb' and 'pci' first entries on the lines are
actually function calls, and the other items in a test line are arguments.

So, as an RFC - how about calling the board files: "<compatible-string>.sh" to make this
clear, and maybe adding a comment at the top about the nature of the file?

There's probably a use case for reading this file not in this original shell script context,
so I think Christopher's point about a machine-readable AND easily human-readable
format is valid.  Personally, I find this format not too bad to read (but then I'm a
shell junky.)

I believe, Nicolas, that you were already planning on putting some comments in the
file to describe the line format (function arguments?), based on feedback from Greg KH.
IMHO, knowing that the format allows comments is useful, so adding a sample
comment would be welcome.
  -- Tim