linux-kernel - Re: [PATCH RFC 0/3] perf/core: Add ability for an event to "pause" or "resume" AUX area tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fXXrfOyNKrP8xu8+c5Wq1L=YgiEGuv6qC5XP5m+8ie9_w@mail.gmail.com>
Date:   Tue, 28 Nov 2023 11:52:49 -0800
From:   Ian Rogers <irogers@...gle.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Hendrik Brueckner <brueckner@...ux.ibm.com>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach <mike.leach@...aro.org>,
        James Clark <james.clark@....com>, coresight@...ts.linaro.org,
        linux-arm-kernel@...ts.infradead.org,
        Yicong Yang <yangyicong@...ilicon.com>,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Will Deacon <will@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: Re: [PATCH RFC 0/3] perf/core: Add ability for an event to "pause" or
 "resume" AUX area tracing

On Thu, Nov 23, 2023 at 4:19 AM Adrian Hunter <adrian.hunter@...el.com> wrote:
>
> Hi
>
> Hardware traces, such as instruction traces, can produce a vast amount of
> trace data, so being able to reduce tracing to more specific circumstances
> can be useful.
>
> The ability to pause or resume tracing when another event happens, can do
> that.
>
> These patches add such a facilty and show how it would work for Intel
> Processor Trace.
>
> Maintainers of other AUX area tracing implementations are requested to
> consider if this is something they might employ and then whether or not
> the ABI would work for them.
>
> Changes to perf tools are not fleshed out yet.

This looks good to me but the perf tools parsing changes I'm not sure
on. It would be nice to have a test case, likely a shell test or
change to the intel-pt shell test, to show how they work.

Thanks,
Ian

> Adrian Hunter (3):
>       perf/core: Add aux_pause, aux_resume, aux_start_paused
>       perf/x86/intel/pt: Add support for pause_resume()
>       perf tools: Add support for AUX area pause_resume()
>
>  arch/x86/events/intel/pt.c                | 12 ++++++
>  include/linux/perf_event.h                |  9 +++++
>  include/uapi/linux/perf_event.h           | 13 ++++++-
>  kernel/events/core.c                      | 65 +++++++++++++++++++++++++++++--
>  kernel/events/internal.h                  |  1 +
>  tools/include/uapi/linux/perf_event.h     | 13 ++++++-
>  tools/perf/util/auxtrace.c                |  4 ++
>  tools/perf/util/evsel.c                   |  9 +++++
>  tools/perf/util/evsel_config.h            |  6 +++
>  tools/perf/util/parse-events.c            | 33 ++++++++++++++++
>  tools/perf/util/parse-events.h            |  3 ++
>  tools/perf/util/parse-events.l            |  3 ++
>  tools/perf/util/perf_event_attr_fprintf.c |  3 ++
>  13 files changed, 167 insertions(+), 7 deletions(-)
>
>
> Regards
> Adrian