linux-kernel - Re: [PATCH v2] usbip: Don't submit special requests twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9c09012-9df8-406b-a299-1310d9c626b2@linuxfoundation.org>
Date:   Tue, 28 Nov 2023 13:31:58 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Simon Holesch <simon@...esch.de>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <shuah@...nel.org>, Hongren Zheng <i@...ithal.me>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] usbip: Don't submit special requests twice

On 11/27/23 17:08, Simon Holesch wrote:
> Skip submitting URBs, when identical requests were already sent in
> tweak_special_requests(). Instead call the completion handler directly
> to return the result of the URB.
> 

Sounds reasonable. What happens when a tweak_* routine does nothing
or returns an error.

tweak_reset_device_cmd() returns 0 when it can't get the device lock
and after calling usb_reset_device().

tweak_set_interface_cmd() and tweak_clear_halt_cmd() return the value
the usb_* routine they call. Don't these cases be handled as well?

thanks,
-- Shuah